Eric Larson

Results 30 comments of Eric Larson

@sigmavirus24 That is a good idea. The entrypoint bit is a pain in the neck, but `--list-heuristics` might be helpful there.

As the date is typically provided by the server, we parse the timezone in order to try to make sure we're making the appropriate comparisons. I can imagine it could...

@josephw Sorry for a slow reply. This looks reasonable, but we need a test ensuring we're passing the timeout correctly. Basically, mocking the `lock_class` and ensuring the arg from the...

@robgil if I understand that response correctly, the 200 is from the original response. The server responds with a 304, which tells CacheControl to use the response it has, which...

My anticipation is that when someone reaches this sort of problem, that it is time to take better ownership of that cached data and consider using something like an external...

@dstufft Did you have any other info on what sort of use case causes the the the invalid cache entries? I have a test for the basic use case, but...

@hakanw Thanks for catching this one! I'll take a look.

@dsully Thanks for bringing this up. Did you run into an issue with lockfile that is fixed with fasteners?

@dsully This is a good point an while I'd like to automate the process based on commit message to improve the release notes (at least keeping them current) I'm doubtful...

I think these changes are looking good to me. It would be nice to break things up a bit. For example, adding all the SPDX, switching to six, etc. in...