ionic-framework icon indicating copy to clipboard operation
ionic-framework copied to clipboard

Published 20 hours ago • verified publisher icon ionic-team

bug: componentProps of modalController does not work with Angular 17.1.0 signal inputs

Open ntorrey opened this issue 3 months ago • 6 comments

Prerequisites

Ionic Framework Version

v7.x

Current Behavior

Passing componentProps (when using a modalController) throws an error when the input of the component is a signal (Input signals are a feature of Angular 17.1.0).

Expected Behavior

The componentProps should work even if the component input is a signal.

Steps to Reproduce

  1. Create a component to pass to a modalController which has signal inputs.
  2. Create a modal controller with componentProps that correspond to the component's input signals.
  3. Open the modal and observe the results with dismay.

Code Reproduction URL

https://github.com/ntorrey/ionbug

Ionic Info

Ionic: Ionic CLI : 7.2.0 Ionic Framework : @ionic/angular 7.6.6 @angular-devkit/build-angular : 17.1.1 @angular-devkit/schematics : 17.1.1 @angular/cli : 17.1.1 @ionic/angular-toolkit : 11.0.0

Capacitor: Capacitor CLI : not installed @capacitor/android : not installed @capacitor/core : not installed @capacitor/ios : not installed

Utility: cordova-res : not installed globally native-run : not installed globally

System: NodeJS : v18.18.0 (C:\Program Files\nodejs\node.exe) npm : 10.4.0 OS : Windows 10

Additional Information

No response

ntorrey avatar Jan 25 '24 01:01 ntorrey

Thanks! Here's a dev build with a fix: 7.6.2-dev.11706205501.196a5433

Note that this is an Ionic 8 build and is subject to breaking changes.

liamdebeasi avatar Jan 25 '24 17:01 liamdebeasi

Seems to work now - thanks for the quick response!

ntorrey avatar Jan 26 '24 17:01 ntorrey

Thanks for testing! I'm going to keep this open until the linked PR is merged.

liamdebeasi avatar Jan 26 '24 18:01 liamdebeasi

Just mentioned it has not been included in v8?

EinfachHans avatar Apr 25 '24 07:04 EinfachHans

No, the PR has not been merged.

liamdebeasi avatar Apr 25 '24 13:04 liamdebeasi

I am also having issue with this, any fixes?

SadraRahmani avatar Apr 28 '24 12:04 SadraRahmani

Woohoo! Can't wait for the 8.2 release. It will be good to finally move off of the dev version I've been using (not in production of course 😬). Thanks for your work on this!

ntorrey avatar May 09 '24 10:05 ntorrey

Thanks for reporting this issue! This has been resolved with https://github.com/ionic-team/ionic-framework/pull/29453 and will be available in the next minor release 🎉

sean-perkins avatar May 09 '24 13:05 sean-perkins