bug: componentProps of modalController does not work with Angular 17.1.0 signal inputs

[ntorrey]

Prerequisites

• [X] I have read the Contributing Guidelines.
• [X] I agree to follow the Code of Conduct.
• [X] I have searched for existing issues that already report this problem, without success.

Ionic Framework Version

v7.x

Current Behavior

Passing componentProps (when using a modalController) throws an error when the input of the component is a signal (Input signals are a feature of Angular 17.1.0).

Expected Behavior

The componentProps should work even if the component input is a signal.

Steps to Reproduce

1. Create a component to pass to a modalController which has signal inputs.
2. Create a modal controller with componentProps that correspond to the component's input signals.
3. Open the modal and observe the results with dismay.

Code Reproduction URL

https://github.com/ntorrey/ionbug

Ionic Info

Ionic: Ionic CLI : 7.2.0 Ionic Framework : @ionic/angular 7.6.6 @angular-devkit/build-angular : 17.1.1 @angular-devkit/schematics : 17.1.1 @angular/cli : 17.1.1 @ionic/angular-toolkit : 11.0.0

Capacitor: Capacitor CLI : not installed @capacitor/android : not installed @capacitor/core : not installed @capacitor/ios : not installed

Utility: cordova-res : not installed globally native-run : not installed globally

System: NodeJS : v18.18.0 (C:\Program Files\nodejs\node.exe) npm : 10.4.0 OS : Windows 10

Additional Information

No response

[liamdebeasi]

Thanks! Here's a dev build with a fix: 7.6.2-dev.11706205501.196a5433

Note that this is an Ionic 8 build and is subject to breaking changes.

[ntorrey]

Seems to work now - thanks for the quick response!

[liamdebeasi]

Thanks for testing! I'm going to keep this open until the linked PR is merged.

[EinfachHans]

Just mentioned it has not been included in v8?

[liamdebeasi]

No, the PR has not been merged.

[SadraRahmani]

I am also having issue with this, any fixes?

[ntorrey]

Woohoo! Can't wait for the 8.2 release. It will be good to finally move off of the dev version I've been using (not in production of course 😬). Thanks for your work on this!

[sean-perkins]

Thanks for reporting this issue! This has been resolved with https://github.com/ionic-team/ionic-framework/pull/29453 and will be available in the next minor release 🎉

[sean-perkins]

👋 this is now available in v8.2.0. Upgrade your apps and let us know if you experience any issues!

Edit:

This feature is opt-in, so be sure to update your Ionic config to include:

useSetInputAPI: true,

[muuvmuuv]

Works! Thanks :)

[ionitron-bot[bot]]

Thanks for the issue! This issue is being locked to prevent comments that are not relevant to the original issue. If this is still an issue with the latest version of Ionic, please create a new issue and ensure the template is fully filled out.