intractabilis

Results 77 comments of intractabilis

My guess would be: your CI bots don't use `BENCHMARK_USE_BUNDLED_GTEST=OFF`. Ubuntu 16, Clang 14 with Clang's libc++. However, the OS is irrelevant, I build the whole toolset myself, it's OS-independent....

I am building Gtest, with the toolset, not with Google Benchmark. Look, I hope this thread is not about my virtues, i.e. what I should or shouldn't do. I also...

> why you have a toolchain that builds googletest with one setup (not c++11) and benchmark with another (it requires c++11 to build). i think it's unsurprising that if you...

> it works, as in, we're able to build googletest as part of the google benchmark project on our CI bots I never questioned that your CI bots work. It's...

> there's even a comment that c++14 doesn't work for some configurations. That was 6 years ago. I am pretty sure it is outdated.

> Does google test specify the minimal required C++ standard in it's CMake Interface? No, otherwise those almighty CI bots would have failed.

> if we set CMAKE_CXX_STANDARD I didn't say `CMAKE_CXX_STANDARD`, I said `CXX_STANDARD`. See: https://cmake.org/cmake/help/latest/prop_tgt/CXX_STANDARD.html

> Well, they should. Someone should fix that first then. It will break those infamous CI bots for Google Benchmark. No, Google Benchmark should be fixed first.

> stack overflow agrees This is a 7-years old post. Modern CMake's approach is all about targets.

> I can only repeat what i have already said: gtest needs to set the C++ standard needed to build it, > and advertise (in it's target interface properties) the...