nishan (o^▽^o)

Results 52 comments of nishan (o^▽^o)

@NickGerleman @javache Any pointers or command how can i run these [transform](https://github.com/facebook/react-native/blob/main/packages/react-native/ReactCommon/react/renderer/graphics/tests/TransformTest.cpp) tests? I'll add some tests here for translate percentage.

@NickGerleman @javache added a [testcase](https://github.com/facebook/react-native/pull/43192/commits/776d67db31482ad364022628ee29ef2ee30f5f58). CI is fine, so hopefully the test is running? Seems to be ready to take another look at this and the other PRs 🙏

Thanks @cortinico Any way i can run these tests locally, just to confirm? i can see it bundles the cpp test files in android local build. But i couldn't find...

Something seems off. FB internal tests are running indefinitely 😅

@kkafar @davidgvf we had seen similar opacity issue and without stripe. I tried reproducing but was unsuccessful. I'll try again. It gets resolved when i changed the default fade animation...

Closing this PR on favor of updated - https://github.com/react-native-netinfo/react-native-netinfo/pull/655. Thanks @j-piasecki.

> High-level thought on the approach here: Could we applytransformOrigin as we calculate the transform matrix on the ShadowNode/ShadowView instead, and avoid having to mutate the transform in the mounting...

@javache can you check this approach? https://github.com/facebook/react-native/compare/main...intergalacticspacehighway:react-native:f/transform-origin-resolve?expand=1 It adds a resolveTransform function that returns a new transform based on the transform-origin and layoutMetrics. This makes sure we get the updated...

@javache sorry for the delay, been out for a trip. I just merged the new approach here so you can review. I'll add the support for old arch and android.

@javache I've updated the code so it works on old/new arch + android/ios. However, I think there is a fundamental issue with the approach I have taken to make it...