python-intercom icon indicating copy to clipboard operation
python-intercom copied to clipboard

Published 20 hours ago • verified publisher icon intercom

Allowing for dynamic object_id for delete call

Open lukas-gitl opened this issue 7 years ago • 4 comments

This is according to how intercoms official api supports this

https://github.com/jkeyes/python-intercom/issues/158

Untested

lukas-gitl avatar Oct 25 '17 23:10 lukas-gitl

Coverage Status

Coverage increased (+0.004%) to 95.858% when pulling 2f3acb0b9572d2508027013183a440db7055d94c on lukas-gitl:patch-1 into 60b14138445d80e165745abe1a3754d250b7d1de on jkeyes:master.

coveralls avatar Oct 25 '17 23:10 coveralls

Coverage Status

Coverage increased (+0.004%) to 95.858% when pulling 62e5f021c6489876ece0b032858f3afc768c4bb8 on lukas-gitl:patch-1 into 60b14138445d80e165745abe1a3754d250b7d1de on jkeyes:master.

coveralls avatar Oct 26 '17 16:10 coveralls

Once concern with this pr is that obj is no longer returned in all cases. I'm curious why an object should be returned from a delete call at all though?

lukas-gitl avatar Oct 26 '17 16:10 lukas-gitl

+1 to delete Leads

aleonsan avatar May 29 '18 16:05 aleonsan