Tim Ramlot
Tim Ramlot
I applied a few hacks and optimisations in https://github.com/kubernetes-sigs/structured-merge-diff/pull/257/commits/59b48609980cc1fdede9bb648650281fd55a13ba and https://github.com/kubernetes-sigs/structured-merge-diff/pull/257/commits/4f4fbffba59b2050d7301a3f9661f089f8f0c70a. These changes improved the performance quite a bit compared to the initial version. However, the performance is still a...
> For context, there were quite a few months of engineering effort to optimize the performance of SSA, and in particular, managed fields. I'm supportive of making this code better,...
@nickwb could you provide some information explaining what your PKI looks like? Why do you need the certificate history when all your certificates can share a common parent certificate?
Thanks @erikgb. Great work upstreaming support for sub-resources. /approve /lgtm
@mikebryant Sorry for the slow reaction. The tests return this error: ``` Helm chart README.md is out of date. Please run 'make update-helm-docs'. ```
/test pull-cert-manager-master-make-verify Looks like a flake: ```bash W0424 16:41:46.572703 14322 report.go:128] Error discovering license URL: getting file URL in library gopkg.in/inf.v0: source.ModuleInfo(ctx, "gopkg.in/inf.v0", "v0.9.1"): moduleInfoDynamic(ctx, client, "gopkg.in/inf.v0", "v0.9.1"): fetchMeta(ctx, client,...
Will continue fixing the test failures on monday.
@yxxhero tests are passing now.