trust-manager icon indicating copy to clipboard operation
trust-manager copied to clipboard

refactor: simplify managed fields upgrade

Open erikgb opened this issue 1 year ago • 2 comments

/hold

erikgb avatar Mar 07 '24 20:03 erikgb

Skipping CI for Draft Pull Request. If you want CI signal for your change, please convert it to an actual PR. You can still manually trigger a test run with /test all

jetstack-bot avatar Mar 07 '24 20:03 jetstack-bot

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Once this PR has been reviewed and has the lgtm label, please ask for approval from erikgb. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

jetstack-bot avatar Mar 07 '24 20:03 jetstack-bot

/test all

erikgb avatar May 06 '24 16:05 erikgb

/unhold /cc @inteon

erikgb avatar May 06 '24 18:05 erikgb

/test pull-trust-manager-verify

erikgb avatar May 06 '24 18:05 erikgb

Thanks @erikgb. Great work upstreaming support for sub-resources. /approve /lgtm

inteon avatar May 07 '24 06:05 inteon

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: inteon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

cert-manager-prow[bot] avatar May 07 '24 06:05 cert-manager-prow[bot]