Ingrid

Can we get a retry on this test failure? It looks unrelated to my changes, and I can't reproduce it. Ran the same commit through CI on my fork and...

Hey @kirawi! This is not tackling undo, I looked at your PR and I don’t think there’s any overlap. I’m going to make a detailed post for discussion on the...

I have no particular attachment to serde or messagepack, so I'll happily switch to bincode. > For session data/something like shada in vim I do like the idea of doing...

Ok, I'll have a go at the multi-file approach then 👍

@the-mikedavis When opening files with their saved position, should the view be aligned to centre? Although I would personally prefer to not align, I noticed that helix aligns to centre...

@gabydd I also don't like that behaviour, though I don't think it's a bug. The code for it looks pretty intentional, and vim notably seems to behave the same

``` fn replace_document_in_view(&mut self, current_view: ViewId, doc_id: DocumentId) { let view = self.tree.get_mut(current_view); view.doc = doc_id; view.offset = ViewPosition::default(); let doc = doc_mut!(self, &doc_id); doc.ensure_view_init(view.id); view.sync_changes(doc); doc.mark_as_focused(); align_view(doc, view, Align::Center);...

I would gladly take that on! It seems though that the work might already be done. I found this PR #7568 by the same author which seems to address the...

Since it doesn't seem like @t-monaghan is coming back for this, and I'm blocked on it for #9143, I decided to take a stab at it. I successfully implemented mapping...

> this is not possible you can't access views from apply Good point. > I plan to remove document and view as separate structs entirely in the future. In that...