Samuel Olugbemi

icon indicating a website link http://portfolio.inspiredstuffs.com/index.html icon indicating an email [email protected]

icon company @gocutover icon location London icon location I am a Java/Ruby on Rails Developer, with solid experience in Hybrid Mobile Application Development (Ionic, Angular, React etc..)

Results 2 issues of Samuel Olugbemi

Overwriting requests agent and other properties with opts.request object

1 comment

Thank you fo this amazing plugin. This is a very minor change that will make this plugin more flexible. I have override the request "agent:" property in `function handleHttp1Req (opts,...

JSON Key Path Fails to Load Even When Readable

About this line: https://github.com/decision-labs/fcm/blob/ec489fa22dd11185d487f781c009bca782144d17/lib/fcm.rb#L296C22-L296C35 I suggest the `json_key` method should look like this: ``` def json_key @json_key ||= if @json_key_path.respond_to?(:read) @json_key_path.read else File.open(@json_key_path) end end ``` This will make it...