insidewhy
insidewhy
~It looks like the render and update calls just need to be called inside an `act()` callback and this will flush the effects, whether using shallow rendering or not. I...
@bdwain Sorry I had a bunch of changes to `ReactShallowRenderer` which I was supposed to remove before adding the `act()` wrapper. Actually the `act()` wrapper changed nothing. It's not that...
@bdwain My PR is here: https://github.com/facebook/react/pull/16168 would be really grateful for your feedback.
BTW it's possible to get this working from enzyme without having to touch react, but you have to override `_createDispatcher` in the shallow renderer to call the original version and...
I needed this feature like... 5 months ago. Which is about the length of time the react maintainers have been ignoring the issue for. If they don't respond to my...
@ljharb Cool, I've written the code now. Having trouble testing it. After running the steps listed in `CONTRIBUTORS.md` I get the following after `npm run react 16`: ``` james@lapchil enzyme...
Okay... so I decided to run it in a container (I chose `node:11`) because I didn't want to run things as root just to get this working (and have lost...
@ljharb Most of the world seems to have moved onto docker-compose instead of `nvm` now, so I don't think mandating nvm is a good idea. IMO using docker-compose is a...
@LeonardPurschke Don't worry I've completed the work and it should be available soon. I'm just waiting on the enzyme Devs to fix the reliability of enzyme's tests so I can...
Okay, if you care more about your own development experience on a community project than that's your prerogative, but it doesn't change the fact that docker is a far better...