faraday

faraday copied to clipboard

Faraday in Eio (some bugs)

3

Hi, I needed a buffered writer in Eio, and I used Faraday as the basis of that (https://github.com/ocaml-multicore/eio/pull/235). While reviewing the code, I fixed a few things that might want...

talex5

Fix compatibility with core >= 0.15

4

Just fixes for the removal of `Core.Unix` in 0.15

bcc32

faraday-async limit iovecs to iovec max

1

I discovered that when using faraday-async while trying to serve large files with httpaf, the writev() syscall would fail with EINVAL because iovcnt was greater than IOV_MAX on my system...

ChrisWills

[drain] would loop infinitely if no bytes were currently pending.

1

This PR fixes this and adds some tests for the [drain] function.

dhouse-js

I'm trying to use faraday with Async like so: ```ocaml open Async let handle fd = let ic = Reader.create fd in let writev = Faraday_async.writev_of_fd fd in let output_buffer...

roddyyaga

seliopou

Refactor dequeue to return option

4

When compiling to JS (via js_of_ocaml) local exceptions used for control flow are getting very expensive (V8 at least). This PR tries to alleviate some of the places, where functions...

Lupus

(reported against Eio in https://github.com/ocaml-multicore/eio/pull/418, which contains fixes and tests) https://github.com/inhabitedtype/faraday/blob/c66fc020fdc2327556c36fc1e912524b427d7da8/lib/faraday.ml#L290-L297 @adatario noticed that the shifts should be in bits, not bytes. Also, the BE version gets the sizes of...

talex5

When writing to a closed `Faraday.t` an exception `Failure "cannot write to closed writer"` is raised. I am observing this exception from `Httpaf.Body.write_string`, and I'm wary of catching all `Failure`s....

reynir