inglorion
inglorion
The unused_mut complaints in src/sys/socket/mod.rs exist before this PR. I've sent PR #2033 to fix those.
#2033 was merged. I've rebased this PR on top of that. I expect it will pass the checks now. I've made a bunch of commits addressing check failures - would...
Does anyone have thoughts on this? @asomers ?
Any comments?
> This PR will break backwards compatibility for callers who pass a `libc::off_t` to Nix, right? What about making these functions generic, like this, and always calling the 64-bit syscall?...
Ok, uclibc is interesting. It can be compiled so that file offsets are always 64-bit (__USE_FILE_OFFSET64) and it can be compiled to provide the *64() functions and off64_t (__USE_LARGEFILE64). However,...
I've made most of the relevant functions use so that they can accept either a nix::off_t or a libc::off_t. This should increase compatibility with existing code. There are, however, still...
Status update, since I've been called away to other duties for a while: u64 is going to be a bit of a challenge, because off_t is signed. This means, among...
> Yes, I wasn't thinking about signedness. `i64` is definitely better than `u64`. The important questions are: > > * Are there any platforms where `off_t` is 32-bits and _don't_...
Happy to contribute. One thing we will have to decide is what the API will look like. I think there is a case to be made for having the regular...