Ximin Luo

Results 364 comments of Ximin Luo

(I am not currently intending to finish this PR, I intend this only as a demonstration of what I meant in #650. It would be good if the maintainers pick...

There is a workaround - annotate those fields with e.g. `#[serde(deserialize_with = "deserialize_bool_from_anything")]` from `use serde_aux::prelude::*;`

For example with microG this is fairly important, since they just have a monolithic app that sometimes needs internet access and sometimes needs LAN access.

I pushed the attempt here in case you want to try it out https://github.com/infinity0/quinn/tree/serde

> [..] but to provide support for saving and restoring state to/from a serialization-friendly form as part of the explicit API This is more maintenance work however, and the serialisation...

I'm not sure how to describe this as part of a higher-level use case! I want deterministic replay of logs so I can deterministically replay logs. :) For context, I'm...

To be clear, I don't think there's any other way for enabling deterministic replay, than making the state serialisable - it's a critical input to how the state machine behaves....

> Using a simulated clock would be a comparatively simple solution to this particular issue. I was talking about this in the context of deterministic replay via a low-level VM...

> we coded them specifically to prevent serialization I think this is well-intentioned but ultimately a mistake, it prevents useful functionality. Much cryptography is designed these days to be deterministic...

@djc I wasn't immediately looking to change anything in rustls, as quinn is flexible enough to support customised crypto. However there are a few other barriers in other core libraries,...