Ximin Luo

@matklad when I last touched that code, yes. the `dev_dependencies_no_check` test is for this.

@ignatenkobrain Cargo already carries this functionality as `cargo build -Z avoid-dev-deps` or `cargo install` (with no extra flags) but only for dev-dependencies, not optional dependencies or unused features or unused...

For the criterion use-case, perhaps we can just have cargo add `--cfg bench` then devs can define `[target.'cfg(bench)'.dev-dependencies.criterion]` in their `Cargo.toml` instead of polluting their dependencies? Currently cargo automatically applies...

Please ignore my previous comments, I think they are obsolete and I have deleted them. As I understand it, the files in `src/**` are all rust translations that do not...

However, you should then remove all references to the `compiler-rt` licenses for clarity. Or perhaps include them for reference, but make it clear that it is the license of `compiler-rt`...

In case people can't be bothered reading the previous links, the TL;DR from the Debian copyright reviewers is that - it's OK for the rust parts of the code to...

That would be consistent with the position as I understand it of the Debian copyright reviewers, yes.

This is not a blocker for Debian, we can just document the license as (MIT or Apache) and Sun-Custom for now, as recommended by the copyright reviewer. I just haven't...

The issues about SunCustom above actually only apply to the libm code, I can't see any similar comments in this crate. So this particular issue can be closed, after the...

LICENSE.TXT is misleading and should just be removed from this repo. In Debian we document the situation here: https://salsa.debian.org/rust-team/debcargo-conf/-/blob/master/src/compiler-builtins/debian/copyright