Oliver

Results 118 comments of Oliver

> Reviewed and added some comments. > > When we are talking about fast builds, would it be possible to run the workflow only if one of the files changed?...

> > @koppor: You could take a look at the `documentation_changes` job inside the documentation workflow and copy and adapt to something similar like the following: > > I used...

@krucod3, @christoph-hamm: Currently, the inter-workload dependencies for deleted workload can not be considered in the case of a Ankaios server or agent restart. The information about the delete dependencies is...

@HorjuRares: It seems like 7 system tests are failing. This needs to be fixed.

I think if the last findings will be resolved, then we can merge the PR. @HorjuRares: Could you create an enhancement issue about refactoring the two occurrences of the `match`...

@HorjuRares: The user documentation must be updated, since the set state command has been changed. Could you fix that? I will check the swdd requirements because some might be need...

I tested the new version of the command to pipe in the changed CompleteState with the nginx restartPolicy of the [Working with the CompleteState section](https://eclipse-ankaios.github.io/ankaios/0.4/reference/complete-state#object-field-mask) and it works. So, I...

It is still possible to fetch parts of the CompleteState over the ControlInterface, e.g. `desiredState.workloads.dynamic_nginx` but not the whole CompleteState. WorkloadStates are also retrievable. A part of the CompleteState can...

@krucod3: After some additional investigation I found out that the "!stateRule" tagging of serde_yaml = 0.9 appears directly inside the `server_state.rs::ServerState::get_complete_state_by_field_mask()` when converting the whole `proto::CompleteState` into the `Object` part...

@krucod3: I have now also implemented a bug fix to keep the serde_yaml for parsing inside the `object.rs`. Like said in the previous comment, The conversion from proto::CompleteState to Object...