Oliver

Results 118 comments of Oliver

@btzeng Amazing, that's what I imagined. There is no better way to solve it. Simple and effective.

@MahmoudMohsenEgy: The changes are looking fine for me. Thanks a lot. I will wait for the swdd requirements and tests. If you need any support, let me know.

@MahmoudMohsenEgy: Thanks a lot for your great contribution. We are currently reviewing your PR. From the first view point of view, the unit tests could be enhanced with testing the...

> @inf17101 Everything is fine, and I've committed it all. Great, thanks a lot. Then I think the first swdd must be linked in the code and last but not...

> > Great, thanks a lot. Then I think the first swdd must be linked in the code and last but not least a few new utests. > > Yes,...

@MahmoudMohsenEgy: Thanks a lot for your great work and efforts. We can now merge this new feature to main. 👍

> Regarding the coverage of `swdd~server-filters-get-complete-state-result-with-wildcards~1`. The stest introduced in this PR somehow covers this requirements, but as this requirements is about the GetCompleteState in general, I think we should...

Uncovered swdd is fixed, I see. But, PR is blocked until #611 is merged. Currently under review.

I started investigating a little bit since three contributors have the same issues. All using WSL2. First, some tests are failing because rootless ports a still kept open after the...

> I think the problem is somehow related to VS Code. When I use VS Code on a Manjora VM and execute the system tests in a dev container a...