Fedor Indutny

Results 187 comments of Fedor Indutny

Hm... you are right, but I was kind of lame to contribute such tests to the project. Perhaps you would like to do it?

Great! That's exactly what I was thinking about, creating defacto asn.1 library for node. Please feel free to ask me any questions if you'll have them, all code is already...

Thank you!

Hello! Thank you for submitting this. Should there be a test?

I don't think that we need `invalid` section, at least not now.

Otherwise LGTM, thank you! ;)

@dcousens looking very good now, except positive-only hex and a failing tests... Speaking of this, I'm not a big fan of having failing tests in repo's master. Would you mind...

@dcousens oh right! Added you as a collaborator to this repo, I hope you don't mind :)

Benchmarks? Last time I checked it - in-place multiplication was a bit slower than regular one. This is why I haven't used it in elliptic.