Fedor Indutny

Results 187 comments of Fedor Indutny

Recognizing recursive pattern as in the issue description is harder, will keep this issue just in case.

That should be most certainly possible. The best way to do it would probably be through separate compilation target. I'll look into it ASAP.

What is the API that your use case requires?

Sorry for delay. Do you need full compatibility with `http_parser` with regards to the fields of `http_parser_url`, or are there some fields that you don't need at all?

@huming2207 unfortunately there is no update on this. Despite originally being shipped together with http_parser, there is no specific need for URL parser to live in llhttp itself. It might...

Hello! Do you mean the methods for converting status code to string?

FWIW, `llhttp_get_status_code` can be used to get the status code out of the parser.

Sorry for very belated response. This is about `HPE_PAUSED` and relevant behavior of the parser. Many callbacks can return `HPE_PAUSED`, but we are not testing much of this...

Would appreciate a PR for that! All `llhttp_data_cb` should return `0` on success and non-zero value will interrupt the parser and make `llparse_execute` set `error` to that value.

Good point. This behavior was ported from http-parser, and I had no idea whether it was still required or not. cc @nodejs/http