Xing Yang

Results 459 comments of Xing Yang

@sonasingh46 pull-kubernetes-e2e-gce-storage-snapshot failed due a different reason (has to do with a snapshot image update that is tracked by a different issue). Please ignore this test. The non-graceful node shutdown...

Closing this testing PR to avoid confusion.

@gracenng Yes, this is targeting Alpha in 1.24.

@gracenng Should this have a Tracked/Yes label?

PRs are submitted here: https://github.com/kubernetes-csi/external-snapshotter/pull/665 https://github.com/kubernetes-csi/external-snapshotter/pull/670

@gracenng It might be better to label this feature as "tracked/out-of-tree" as all the code changes are out-of-tree.

Here's the doc PR: https://github.com/kubernetes/website/pull/32673

> This enhancement proposal mentions the annotation snapshot.storage.kubernetes.io/allowVolumeModeChange. Would it be possible to deprecate that in favor of a more conventional snapshot.storage.kubernetes.io/allow-volume-mode-change? We could do that in 1.25.