wcampbell

Results 149 comments of wcampbell

Running the benchmarks (which aren't a full holistic picture of this library), gives me some worrying numbers. :grimacing: These are ran on my cheap laptop: origin/master..JuanPotato/master ``` deku_read_byte time: [35.971...

Running benchmarks on my [adsb library](https://github.com/rsadsb/adsb_deku) after switching deku to this branch: ``` lax_messsages time: [1.5287 s 1.5305 s 1.5330 s] change: [+56.845% +57.120% +57.449%] (p = 0.00 < 0.05)...

> Thank you for the feedback! Yeah that's not great performance, and I'm also thinking my code might have some bugs in it in very specific cases, Will add some...

@myrrlyn I see you updated bitvec w.r.t. performance with the https://github.com/bitvecto-rs/bitvec/commit/4de627722c6e5b31107e2765fc2ebd7d8c69a84c commit. When updating the `Cargo.toml` of this update branch ```diff diff --git a/Cargo.toml b/Cargo.toml index 14d1a0a..ebfb0c0 100644 --- a/Cargo.toml...

> By any chance, does the faster old version have `#[inline]` on non-public functions I'm not at my computer, but I think this branch is the code that's used for...

as of bitvec v1.0.1, compared to old bitvec: ``` deku_read_byte time: [15.651 ns 15.732 ns 15.806 ns] change: [+93.359% +94.661% +95.905%] (p = 0.00 < 0.05) Performance has regressed. deku_write_byte...

Better https://github.com/wcampbell0x2a/deku/tree/update-bitvec-1.x.x: ``` deku_read_byte time: [11.777 ns 11.799 ns 11.822 ns] deku_write_byte time: [50.278 ns 50.330 ns 50.383 ns] deku_read_enum time: [20.374 ns 20.398 ns 20.422 ns] deku_write_enum time: [84.699...

@sharksforarms would this require something like https://github.com/sharksforarms/deku/issues/105? I'd also like a solution to this use case.

Add community section for showing open-source projects using library?

> Add community section for showing open-source projects using library? I don't know where you would want this, bug I'd be happy to show off my https://github.com/wcampbell0x2a/adsb_deku crate as an...