Results 163 comments of Marc Busqué

> @waiting-for-dev can you try to re-run the CI? Done. It's 🟢 now.

It looks like https://github.com/solidusio/solidus/blob/3b30854712cc7c50fb49a2ee461b848d938c5ca7/backend/app/controllers/spree/admin/users_controller.rb#L58 will return `true` no matter what. @iLucker93, do you want to work on it? I'll happily provide any help you need.

The idea is to deprecate `solidus_frontend` eventually, so maybe we should not worry too much about it. However, changing `#add` to return false would be a breaking change in itself,...

BTW, we should make sure that the raising on `#add` is not used to abort a transaction somewhere else.

Hey, @RyanofWoods! Would you still like to work on it? As a minimal change, we could fix rendering the validation errors to the end-user instead of raising them.

Hey, @RyanofWoods, pinging you again, in case you'd like to complete it 🙂

> @waiting-for-dev Are you encountering the same issue as @johnpitchko ? I also removed cached images and I didn't find the problem so far :thinking:

I think that having another person able to reproduce it is enough to merge it. I don't understand how the machine in use could have any effect (that's the whole...

> I am thinking that rebuilding the image with mysql-client still works for you both @waiting-for-dev and @gsmendoza, because the apt-get packages are cached thinking IIRC, I removed the Docker...

The deletion logic can now be configured. See https://github.com/solidusio/solidus/pull/4471. We can still provide more robust support. Moving it to discussions.