Results 163 comments of Marc Busqué

Hey! This one is ready to be merged, but the naming is holding it back :slightly_smiling_face: What about `check_shipments_and_restart_checkout`?

Hey @spaghetticode, sorry for the hassle, but, can you rebase from master so that specs are green?

Thanks for your contribution, @Naokimi. You're right; some inconsistencies ideally should be fixed. However, my concern is that we're trying to encompass two different things with a common abstraction that...

`/logout` endpoint is a `DELETE` one, not `GET`. It looks like you're missing requiring `rails-ujs`, or maybe you have a previous JS error that is making it unavailable. Please, see...

Closing, as it looks it's been fixed on 3.0 and we're no longer supporting 2.11

Hey @NewAlexandria, it looks like tests are failing. Would you like to keep working on it? :slightly_smiling_face:

Hey, @mamhoff, do you think that we should therefore close it?

That's a great idea! I just wrote something related but for the service objects: https://github.com/solidusio/solidus/pull/4138#issuecomment-890825954 We could do the same for models. We can auto-register all of them and allow...

Hey @softr8, I rebased from master, and it looks like some tests are failing. I know it's been a while, but do you have a clue which could be the...

I also think it's ok to remove it. In the end, it only gives easy access to the visual appearance of Solidus, and the demo app already does that. For...