Alex Goodman

Results 304 comments of Alex Goodman

Changing `VirtualPath` on the java metadata from a string to a slice of string is very tempting, however, doing this would be inconsistent with how we merge packages today (which...

I think this would be a relatively low lift and add value here 👍 . The goal would be to add these for each ecosystem under the package `metadata` section...

I did! Right after finding this lib -- It's an awesome tool 🥇

The artifact in ArtifactHub is currently a test image and needs to be replaced with an official image before this issue can be considered done.

looks like the github actions are not being kicking, maybe due to https://www.githubstatus.com/incidents/8xxms3q3qzgp

For reference about what this is doing: - https://stackoverflow.com/questions/63831540/removing-module-path-in-trace-in-go - https://github.com/golang/go/issues/34186 - https://github.com/golang/go/issues/33772#issuecomment-528176001

@developer-guy out of curiosity, why the change to explicitly specify GOPATH in the workflow files?

I see the reason for `trimpath`, but what I'm referring to is: - https://github.com/anchore/grype/pull/642/files#diff-e426ed45842837026e10e66af23d9c7077e89eacbe6958ce7cb991130ad05adaR143 - https://github.com/anchore/grype/pull/642/files#diff-f3c08cd4e56926b1732a8183a4eb36057b86d9503161db0021350279b18144a7R184 Where there was a change to explicitly set `GOPATH: /home/runner/go`. I'm confused as to...

> I've replaced with ${{ env.GOPATH }} this one. Right, but doesn't this do nothing? ``` env: GOPATH: ${{ env.GOPATH }} ``` ... since this is setting an environment variable...

Clarifying question: why not use the built in goreleaser `{{.CommitDate}}` variable? Is there a functional difference between that and the makefile updates you made? I can't seem to parse the...