Alex Goodman

Results 304 comments of Alex Goodman

Separate from the options (but related) is the configuration object used to describe behavior. Based off of the options and todays configuration, I propose a `CatalogingConfig` that looks something like...

from refinement: - try to be minimal with the options - are there any more global default functional options that could be used here? (not just individual catalogers, but across...

> not sure if there's a way to extend (not override) the list of default package catalogers with the proposed API @lyzs90 there is one way with the proposed API,...

**_update: see https://github.com/anchore/syft/issues/558#issuecomment-1081846913 for a more up to date suggestion_** Most of this conversation has been about the `syft` package, however, that top-level API may require callers to use other...

In a similar vein to the last comment about package organization, I wanted to touch on the differences between the `file` and `pkg` packages. The current organization of `pkg` is...

Focusing on the relationship between the `source` and `file` packages, there are some concepts that are currently in the `source` package that semantically belong in the `file` package. For instance,...

Focusing on the `source` package in particular: - it seems that the `source.Scheme` could be disambiguated to be a `source.Type` and the helper function `source. DetectScheme()` could be renamed to...

I've made a mockup of the proposed changes in the above comments, feel free to try it out here https://github.com/anchore/syft/tree/api-wip (this is just for illustration and prototyping, not for merging...

_Incorporating comments from refinement_ The proposed package structure for `pkg` has a few drawbacks: - `cataloger/packages` is a sibling package of the other individual package catalogers, which hints that they...

**Summary of tasks** Group: organize definitions (details in https://github.com/anchore/syft/issues/558#issuecomment-1075716731 and https://github.com/anchore/syft/issues/558#issuecomment-1081846913 and https://github.com/anchore/syft/issues/558#issuecomment-1075670017 ) - [x] migrate file definitions to `syft/file` #1751 - [x] rename `pkg.Catalog` to `pkg.Collection` #1764 -...