Volkan Yazıcı comments

Results 180 comments of


                                            Volkan Yazıcı

ClientAbortException handling discrepancy between exception and request handlers

Thanks for your prompt response @rstoyanchev, appreciated. > You can add an @ExceptionHandler and use that to log as needed. I could not follow you on how to handle the...

ClientAbortException handling discrepancy between exception and request handlers

@rstoyanchev, please see the following test where `testWork()` succeeds whereas `testCollapse()` fails: ```java import ch.qos.logback.classic.Level; import ch.qos.logback.classic.LoggerContext; import ch.qos.logback.classic.spi.ILoggingEvent; import ch.qos.logback.core.read.ListAppender; import org.apache.catalina.connector.ClientAbortException; import org.assertj.core.api.Assertions; import org.junit.jupiter.api.Test; import org.slf4j.Logger; import...

ClientAbortException handling discrepancy between exception and request handlers

> @vy thanks for the extra sample but I can't debug that at the moment. I can assure you there is no reason why an `@ExceptionHandler` won't apply in this...

2.12.0 XmlMapper regression: no default no-arg ctor found

I am able to reproduce the failure with the following dependencies: - `jackson-annotations` 2.13.0-rc1 - `jackson-databind` 2.13.0-SNAPSHOT (locally built from the `2.13` branch of the repo) - `jackson-dataformat-xml` 2.13.0-rc1 >...

2.12.0 XmlMapper regression: no default no-arg ctor found

* I can reproduce the failure in 2.12.5. * I don't know of a way to reproduce this without the mix-ins, sorry.

Quick survey of git "merge commits" in open source projects

Interesting list @lukego. I also wonder the same question: What do the merge commits really tell us?

Streamable interface for SAX-style message rendering

I believe this PR is resolved by other means in #17, hence I am closing it. Feel free to poke me if you think otherwise.

Streamable interface for SAX-style message rendering

@mkedwards, ok, then I am re-opening it.

Streamable interface for SAX-style message rendering

I found these two particularly useful: - [Use log4j2 ConfigurationSource to find config file](https://github.com/nexiahome/log4j2-logstash-layout/commit/5f0226deeee08e4725b5eab0d5af6314c4ee435e) - [Use maven-jar-plugin to generate package metadata in manifest](https://github.com/nexiahome/log4j2-logstash-layout/commit/f7f9e979b1267d9a67fa222d3a3c76a98ccbf428) The rest looks to be nexia-specific to...

BufferOverflowException occurs intermittently when sending data via socket appender

@johnament, thanks for the report and detailed analysis. `LogstashLayout` is superseded by [`JsonTemplateLayout`](https://logging.apache.org/log4j/2.x/manual/json-template-layout.html) of `log4j-layout-template-json` module since Log4j 2.14.0 release. (I have just placed a warning about this to `README.md`.)...