Volkan Yazıcı

Results 192 comments of Volkan Yazıcı

``` Error: Failed to execute goal org.apache.maven.plugins:maven-compiler-plugin:3.10.1:compile (default-compile) on project log4j-core: Compilation failure: Compilation failure: Error: /home/runner/work/logging-log4j2/logging-log4j2/log4j-core/src/main/java/org/apache/logging/log4j/core/async/DisruptorBlockingQueueFactory.java:[21,42] error: cannot access DisruptorBlockingQueue Error: bad class file: /home/runner/.m2/repository/com/conversantmedia/disruptor/1.2.20/disruptor-1.2.20.jar(com/conversantmedia/util/concurrent/DisruptorBlockingQueue.class) Error: class file has...

Thanks so much @quapka! Applied your changes to both `release-2.x` and `master`.

@jsoref, even though we appreciate your contribution for code clean-ups, it is quite time consuming for us to review every single line, in particular, given your changes span across hundreds...

Isn't there a mechanism we can hook into to take a snapshot of existing properties before and restoring them after a test method?

> Yes, there's an app for that ;-) https://junit-pioneer.org/docs/system-properties/ The reason I did not mention about `system-properties` of JUnit Pioneer is that it operates on an input list of properties,...

> The issue is that currently some tests are still using JUnit 4. For that there is the [System Rules](https://github.com/stefanbirkner/system-rules) project, but I did not want to add two separate...

I am working on a throttler for [Log4j 2 Redis Appender](https://github.com/vy/log4j2-redis-appender). While calling `Jedis#rpush(String key, String... strings)`, I need to provide an array as a second parameter. For that purpose...

We suffer from the same issue in Log4j. For instance, consider `log4j-core-its` module. Its `src/main` is empty and `src/test` contains tests. When `./mvnw foo:bar spotbugs:spotbugs -pl log4j-core-its` is issued, *if*...

> How are you running SpotBugs @vy? Effectively via `./mvnw spotbugs:check`, see [pom.xml](/apache/logging-parent/blob/main/pom.xml#L674) for details. > In the SonarQube plugin we have added the `sonar.findbugs.allowuncompiledcode` option for that type of...

@Marcono1234, ASF projects don't have access to project settings view in GitHub. We can indirectly change settings via [`.asf.yaml` files](https://cwiki.apache.org/confluence/display/INFRA/Git+-+.asf.yaml+features). Hence, yes, I needed to roll out the branch renaming...