ch.vorburger.exec

ch.vorburger.exec copied to clipboard

exec hangs when program not found

7

Michael, with the exec package, it seems to hang when the program to run is not found. Debugger shows that the IOexception was not caught and things kept moving forward...

shague

Unexpected error when calling waitForExit

6

Here's the issue that we're seeing: ``` ManagedProcess process = builder.build(); process.start(); process.waitForExit(); // Crashes the error below: ``` `waitForExit` fails with this: ``` Caused by: ch.vorburger.exec.ManagedProcessException: Asked to waitFor...

mihneagiurgea

checkResult() should be optional

1

The `waitForExit()` methods currently internally (all?) use `checkResult()`. This makes it impossible to wait for a non-sucessful exit - which could be handy for some use cases (e.g. a CLI...

vorburger

Performance issue

2

The `wait(100)` in `ch.vorburger.exec.ManagedProcess.startExecute()` isn't great. Wouldn't some sort of `yield()` (:question:) suffice?

vorburger

When using this library somewhere where there already is a "command line" (as in an executable + arguments), then the `ManagedProcessBuilder` as-is currently is more in the way than helpful,...

vorburger

`ManagedProcess` ideally should have something like a `startWaitGetOutput()` which would: ``` java p.start(); if (p.waitForExit() != 0) { throw fail(p.getProcLongName() + " did not return 0"); } return p.getConsole(); ```...

vorburger

There ideally should be a `setConsoleBufferMaxLinesUnlimitedMemory()` kind of method to create "unlimited" output buffering.

vorburger

For a new personal project I'm toying with, I'd actually prefer it now if this great old library of mine would separate its core functionality from the currently built-in and...

vorburger

Add an exec testing framework or mock

2

A testing mock or other suggestions for adding UT's would be useful. Possibly adding an exec mock that could allow simulating a test program and returning different error codes and...

shague

Bumps org.apache.commons:commons-exec from 1.3 to 1.4.0. [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a...

dependabot[bot]