ch.vorburger.exec icon indicating copy to clipboard operation
ch.vorburger.exec copied to clipboard

checkResult() should be optional

Open vorburger opened this issue 4 years ago • 1 comments

The waitForExit() methods currently internally (all?) use checkResult().

This makes it impossible to wait for a non-sucessful exit - which could be handy for some use cases (e.g. a CLI testing tool).

vorburger avatar Nov 15 '20 21:11 vorburger

I think this is potentially related: https://github.com/vorburger/ch.vorburger.exec/issues/47

mihneagiurgea avatar Dec 07 '20 22:12 mihneagiurgea

@mihneagiurgea your #47 is a "bug" where an external process which is expected to exit with 0 (mysqld) is handled wrong. I suspect #96 actually fixed that problem.

This issue however is an "enhancement" to make this library usable to exec something which one is expecting (!) to have a non-zero exit code. One example of this is my use of this library for the Executable Markdown of Enola.dev, notably to avoid this (very) ugly initial workwaround.

vorburger avatar May 08 '23 00:05 vorburger