Mahamed Ali

Results 147 comments of Mahamed Ali

@howardjohn I pulled this from https://github.com/istio/istio/blob/master/samples/addons/extras/prometheus-operator.yaml I found additional ones here too, but the ones in my PR are sufficient to collect metrics. https://github.com/istio/installer/blob/master/istio-telemetry/prometheus-operator/templates/servicemonitors.yaml

That is a common gotcha for why Prom Operator doesn't pick up ServiceMonitors/PodMonitors in different namespaces. Add this to the prom-operator helm chart: ``` # helm upgrade --install prometheus prometheus-community/kube-prometheus-stack...

`make lint` is very slow on my Mac. I hope this commit fixes it.

Forgot to mention this in the meeting but can you look in to [moving](https://docs.github.com/en/repositories/creating-and-managing-repositories/transferring-a-repository) the repo instead? You can retain the issues, PRs, and releases instead of just moving over...

Hi, can we merge this? I want to use this feature

/remove-lifecycle rotten