ᴊᴏᴇ ᴄʜᴇɴ comments

Results 333 comments of


                                            ᴊᴏᴇ ᴄʜᴇɴ

Security checks for Json()

In conclusion, yes!

LDAP authentication: fetch SSH public keys from LDAP

Thanks your info! > Gogs could use these keys for SSH authentication. I think it could only work when you use builtin SSH server... otherwise, Gogs needs to constantly pull...

LDAP authentication: fetch SSH public keys from LDAP

Any thoughts regrading this issue?

LDAP authentication: fetch SSH public keys from LDAP

@jaydio > When fetched initially the keys should be stored within the MySQL database (not sure if that's already the case, can't check right now). Yes, it is.

LDAP authentication: fetch SSH public keys from LDAP

@psuet Hi, how would I setup a such LDAP backend so I can test while developing?

LDAP authentication: fetch SSH public keys from LDAP

@psuet thank you! Very helpful!

gogs demo site SSL config is wrong and can't be bypassed

Hi, thanks for reporting! The demo site should be back to business by now 😁

storage/postgres: add `NewWithDB` to allow accepting an established `*sql.DB`

Hi, > * How/where are you planning to use this new function? Are you going to send a follow-up PR? Or is this just a refactor? We are already using...

storage/postgres: add `NewWithDB` to allow accepting an established `*sql.DB`

> > > * Could we apply the same change to the Postgres adapter please? > > > > > > Where exactly is the "Postgres adapter" you're referring to?...

storage/postgres: add `NewWithDB` to allow accepting an established `*sql.DB`

Hi @miparnisari, who should I ask for reviews for this PR?