ᴊᴏᴇ ᴄʜᴇɴ comments

Results 333 comments of


                                            ᴊᴏᴇ ᴄʜᴇɴ

fix some typos

> can you work with git-tag's on this repo for versions because of go1.13 Not everyone is on Go 1.13.

Destory => Destroy?

@mjtrangoni yes, that's why the issue is still not fixed by no major release is planned anytime soon...

Destory => Destroy?

Using Go Modules and push out a v2 release seems ideal.

Flush() or Delete() doesn't work in mysql

Thanks for the feedback! I think you're right, probably just remove code block that checks for `len(s.data) == 0`? https://github.com/go-macaron/session/blob/d2c984b2801fbcd84b925838628e39d18649846a/mysql/mysql.go#L80-L83 `Flush()` is meant to remove every key but still need...

有没有 oauth2 服务端的中间件？

这个貌似好像没有！

有没有 oauth2 服务端的中间件？

备份： - https://github.com/RangelReale/osin - https://github.com/gernest/hero - https://github.com/RichardKnop/go-oauth2-server

Custom validation on the documentation can not be compiled (undefined "rule" error).

Hi, please update this package and check out new docs for custom validation rule: https://go-macaron.com/docs/middlewares/binding#custom-validation-rules

Multiple sub-forms from html not json ?

Hi, I pushed a patch to fix **Required** check for slice, please help test!

Security checks for Json()

JSON is stream parse, but form parse needs pre-read in https://github.com/golang/go/blob/700e969d5b23732179ea86cfe67e8d1a0a1cc10a/src/net/http/request.go#L1130:6 . MaxBytesReader is sufficient enough.