Tomas Zemanovic comments

Results 111 comments of


                                            Tomas Zemanovic

Prepare PoS VP for mainnet

that's right, I think only thing we might need to check is PoS params changes from an accepted gov proposal

Code coverage audit, rework to obtain coverage w/o large E2E tests

to my knowledge `make test-unit-coverage` skips e2e

Code coverage audit, rework to obtain coverage w/o large E2E tests

I agree that MASP should have unit / integration / prop tests. There's nothing to catch issues in it besides e2e tests and the lack of these tests is being...

refactor WASM memory data passing with strict provenance

to be done

CI: check that there are no artifacts after e2e tests run

> @tzemanovic what is the status of this? still open

consider using `std::io::Error` in place of `storage_api::Error`

a new alternative that improves many things in error handling: https://github.com/hashintel/hash/tree/main/libs/error-stack

consider using `std::io::Error` in place of `storage_api::Error`

another new crate that provides nice error handling ergonomics without giving up type-safety https://crates.io/crates/terrors (can be used in combination with some other crate)

fix fst epoch start height in apps tests

there's some issue with the unit tests - when I run `make test-unit` locally I get stuck on `test_oracle_reactivation`, but when I run it on its own it passes (even...

Add more randomness to address generator

> Does this need to be secure randomness? Can it be local randomness? What is the usage of these addresses? I think it can be e.g. from a block hash...

Add more randomness to address generator

> @tzemanovic @juped What is the purpose of the address? Is there no private key that should define the address deterministically? Established addresses are not derived from keys. They must...