Tomas Zemanovic

Results 111 comments of Tomas Zemanovic

> Is the issue related to (or subsumed by) #6? it's related but each is for a different purpose

> this is done in the `build_*` function of every tx by passing `tx_args` but both `init_validator` and `change_consensus_key` dont have it :( ah, I see

also rm the `vp` field from `genesis::transactions::ValidatorAccountTx`

> @tzemanovic do you know the current status of this? This is still open. We do have events that replaced tendermint ones from https://github.com/anoma/namada/pull/587 now, which should help a lot

Besides the easy-to-stop unwraps, there are plenty other things that can panic - imho it's essential (and beneficial as the code evolves) to write tests covering the tx/vp execution, especially...

Hi, we ran into the same issue in https://github.com/anoma/namada. In our use case we're using singlepass compiler and we cache compiled `Module`s in memory. This is what we observed on...

there's a commented out bench `fn slash_fund` in `crates/benches/native_vps.rs` - if there's a special native VP we can revive it or remove otherwise

we're using it in https://github.com/anoma/namada / Anoma, but as you mentioned, we're using borsh so we're not affected

> can we move ibc back to wasm now? @Fraccaman I'm not sure, it was an issue with M1/M2 which might still be there (https://github.com/anoma/namada/issues/1831)

> Looks good to me in general, just left a couple questions. thx! I fixed all the issues in https://github.com/anoma/namada/compare/ec36ae148190e183c70cc0c56171aa3bb8b1d359..31e54b9fcccb58d5628cc0362597d5848b576796