Dominic Gannaway comments

Results 195 comments of


                                            Dominic Gannaway

on:load does not trigger on <script src=...> tags

This is something that also was not working in Svelte 4. Specifically, the script element has already loaded from SSR and when hydration occurs, the event listener gets added too...

Binding focus state to elements

Why do we need this? You can just check if something is focused by using `document.activeElement`.

Binding focus state to elements

Write access is tricky with focus. If you try to bind focus to two elements by accident, you cause so many issues with accessibility. It's much better to handle focus...

Binding focus state to elements

Sorry, I don't think this is something we want to invest our time into now. Like I said, focus is complicated and easy to mess up and hard to debug...

Binding focus state to elements

Actually, I think this would be best if it was read-only, rather than writable. Then I can see a way forward for the PR too :)

Binding focus state to elements

@RaiVaibhav Sure, go for it :)

Svelte 5: Nonstate reference warning is too aggressive

This has been fixed.

fix: improve transition outro effect

Update: I'm still not happy with this (I pushed some fixes but they're not right still). It turns out that this is far more complicated to get right. Here is...

fix: improve transition outro effect

@xamir82 This is fixed now :)

creating state inside derived expressions should be forbidden

This is complicated. This is only true of primitive state, but for deeply nested state, it's the only way some patterns can work unless you invoke effects to sync state...