Dominic Gannaway

Results 195 comments of Dominic Gannaway

I'm not sure the best plan of action here. It seems our internal Babel transform for this is not spec compliant yet the one we use on Github is? If...

I thought this was handled with `realm.suppressDiagnostics = true;`?

@akidee Sorry to say, but Prepack isn't being maintained anymore by Facebook.

@akidee Where was that quote from? AFAIK that is not the case.

@akidee Sorry for the confusion. I've updated the README and removed this part, as it is no longer the case.

In regards to your question, yes, making things simple assumes they are partial too in this given case: https://github.com/facebook/prepack/blob/master/src/values/AbstractObjectValue.js#L164 In my opinion though, I think we should remove the whole...

@rahilvora Thanks for looking into this. You have a Flow error in your PR, if you can check? Seems that you are using `CompilerDiagnostic` without the right number of arguments.

Just thought I'd let people know, if you're using your own ref, be sure to `null` it out in an effect otherwise this can lead to memory leaks – especially...

In the case of forks/transitions, the computed would need to re-fire providing the new value. I guess the one thing here to consider is that the computed must be a...

Has any progress been made on this? I'd love to see how minimization is done.