Lyes Touati comments

Results 9 comments of


                                            Lyes Touati

Is it possible to check if key can decrypt ciphertext?

I think it is an interesting functionnality. Because we should always test first if our key is elligible to decrypt or not.

Make command returns error in ubuntu 18.04

I got the same error when trying to install openABE on a debian docker container. **I fixed by installing git!** Hope this helps you.

construction from hex strings

Handling any other base would have been better

Add support for hexadecimal string in constructor

Handling many bases is better in my opinion

'gpac' hanging with incorrect option formatting

You should try: `gpac avgen:dur=1/25 -o f.ts`

Fixes in print_filters function

The command line `gpac -h jsf:js=script.js` still doesn't work It seems that [this if statement](https://github.com/gpac/gpac/blob/5df43d8626d8232271f4b9c31efa944185964996/applications/gpac/gpac_help.c#L2196) is causing the issue

Ensure Enum Arguments are of u32 Type

There is an inconsistency in the code: the argument [ufadts.mpeg2](https://github.com/gpac/gpac/blob/9c261926c5e70647420db9a1ae1f2f085b64b8f1/src/filters/rewrite_adts.c#L397) is an enum but it's declared as a [Bool](https://github.com/gpac/gpac/blob/9c261926c5e70647420db9a1ae1f2f085b64b8f1/src/filters/rewrite_adts.c#L38) and is also treated as a boolean throughout the code. @jeanlf...

Ensure Enum Arguments are of u32 Type

@jeanlf Thanks for the update! Now that the `mpeg2` option fix is merged into master, this PR is ready to go as well. Feel free to merge it when convenient.