Tymoteusz Motylewski

Results 125 comments of Tymoteusz Motylewski

@elidrissidev for me having php-cs-fixer as dev-dependency is not a blocker from my POV

@luigifab this change is too big for a review. As I also need phpcsfixer rule in some other PR, I propose the following: Can you provide a phpcsfixer configuration, composer...

@luigifab i suggest following: 1) in a separate PR add a php cs fixer config and github action which goes green without much (or any) code change 2) lets merge...

Looks good by reading, I would just exclude zend from the check, as this would make harder to spot differences between zend versions (there is a separate discussion around zend)....

I would love to have php-cs fixer in place. This change however is missing few pieces: 1) php-cs-fixer configuration file (lets start with config which is not making too much...

@joshua-bn can you push a PR with your changes?

@greglamy do you have any stats showing the performance improvement? Does your patch also handles the updating the core_rewrite table when url is changed? AT first glips I didn't find...

You should have separate composer json and composer lock for your projekt. This one is for openmage core only. Without it we had several situations where CI stopped working because...

@sreichel im ok with any approach which will give us stability on CI builds.