magento-lts icon indicating copy to clipboard operation
magento-lts copied to clipboard

Chore: Add Captainhook & PHPCS to composer require-dev and sample captainhook config

Open kkrieger85 opened this issue 5 years ago • 3 comments

Add captainhook and PHPCS to composer require-dev section Add sample captainhook config

closes #1120 (duplication) refs #947 #982

Please consider, that commit hooks are disabled in captainhook.json

You could test it by installing packages with composer and using the PHPCS Rule with using the command in captainhook.json

kkrieger85 avatar Oct 18 '20 13:10 kkrieger85

I would love to have php-cs fixer in place. This change however is missing few pieces:

  1. php-cs-fixer configuration file (lets start with config which is not making too much changes in the codebase - and add new rules later on
  2. github action to validate codestyle on PR
  3. use friendsofphp/php-cs-fixer v3 instead of v2

tmotyl avatar Aug 06 '21 08:08 tmotyl

Feel free to update my PR

kkrieger85 avatar Aug 08 '21 11:08 kkrieger85

Seems related to #2400

sreichel avatar Aug 10 '22 22:08 sreichel