Tim Abbott

Results 1245 comments of Tim Abbott

> Because this PR is going to be huge and it is unlikely to be completed without running into merge conflicts, perhaps we can start reviewing & merging part of...

Does the code run locally? I suspect that's just a Python error, and provision is the first bit of code that tries to import Zulip code in the test suite.

I think we can start doing a bunch of small commits that do e.g. `assert foo is not None` to clear batches like this in tests: ``` zerver/tests/test_push_notifications.py:715: error: Item...

I merged the two commits ending with , which fix some really confusing variable names and typing inside the `gather_subscriptions_helper` code path that I found while skimming what errors remain....

I also merged the series ending with 01ce58319d4748d4549f196d7c54726680330ffd to fix a few type errors that stood out to me when skimming them.

Down to only 910 errors; awesome progress on this!

Nice! I've merged both of those PRs, so you should be able to keep moving on this.

It's awesome that this is down to 600!

I merged the RequestNotes PR. Looking through what remains, I don't see much in the way of big refactors we'll need to do. A few notes: * `analytics/views/user_activity.py:45: error: Missing...

> [attr-defined] "HttpResponse" has no attribute "url" zerver/tests/test_signup.py:5754 I assume these are for checking redirects? I bet we could address this class of things by adding an test helper `self.assert_is_redirect_with_url(result,...