Tim Abbott

Results 1245 comments of Tim Abbott

@YJDave thanks for working on this! Can you rebase? Also posted a few small comments.

When I try using this, I get this error: ![image](https://user-images.githubusercontent.com/2746074/37233015-565c981a-23a6-11e8-9421-67b5dd39a793.png)

It appears the password reset email is being sent.

Well, those can be address using unicode normalization. Which we might want to use here.

@zy964c can you rebase this, rather than creating merge commits? They don't really work with GitHub PRs. Check out our [GitHub guide](https://zulip.readthedocs.io/en/latest/git-guide.html) and [commit guidelines](https://zulip.readthedocs.io/en/latest/contributing/version-control.html) for more details.

This is a cool idea. I'm not sold on the precise UI (I kinda feel like as a user I'd want to actually specify which type of thing I'm entering),...

I merged the first commit, and posted a couple comments.

I think the behavior to uncheck users who were on a stream you uncheck was intentional, though it's hard to say what the correct behavior here should be. I think...

This is great; merged with the small adjustments to docstrings noted above. I agree with the next steps of refactoring away `rate_limit` and cleaning `remote_server` out of `RequestNotes`; and see...

@Kumar-Tarun you need to work on making your changes comprehensible. E.g. why did you move `test_with_external_user` to a different section of the test file? The tests pass without that change,...