Tim Heckman

Results 104 comments of Tim Heckman

@daniellockard to confirm: would this is would result in a compile-time breaking API change?

@daniellockard thank you for taking the time to comment. That makes sense, and I'll keep this PR on-deck for whenever we look to release v2.0.0. Thank you for the contribution,...

@ricardoasmarques can you please point me more precisely within the documentation where it says a `template` can be used? I took a look at the link, expanded all fields, and...

Also, sorry for not replying sooner. I somehow missed this issue. 🤦‍♂️

Yikes. So looking at that we're probably going need a breaking change to support this. 🤦 I guess we could add the field, and add a check for both `target`...

Another example: https://github.com/PagerDuty/go-pagerduty/blob/e23b94cea01f37da371fd9d7efb4e20ea0e36ff2/webhook.go#L32

https://github.com/PagerDuty/go-pagerduty/blob/da97010e7f22b22d88b2a9e4b0eb6e7c4566721f/incident.go#L80 https://github.com/PagerDuty/go-pagerduty/blob/da97010e7f22b22d88b2a9e4b0eb6e7c4566721f/incident.go#L60-L64 https://developer.pagerduty.com/api-reference/b3A6Mjc0ODE0MQ-get-an-incident

https://github.com/PagerDuty/go-pagerduty/blob/77a73c9d16987b91549d60d76d5a075e91400df9/on_call.go#L11-L13

I think this method may be what you want: https://pkg.go.dev/github.com/PagerDuty/go-pagerduty#Client.ManageIncidentsWithContext

@jspaleta do you know, does the Events API return an error if you try to submit a payload larger than 512KB? Or does it silently swallow it? If this returns...