go-pagerduty icon indicating copy to clipboard operation
go-pagerduty copied to clipboard

Adding proper types for Links and Images

Open daniellockard opened this issue 6 years ago • 3 comments

I think this is correct? It should make code easier to write instead of writing something like

Links: []interface{}{
			map[string]string{
				"href": "https://link.to.thing/thing",
				"text": "Link",
			},
		},

daniellockard avatar Oct 17 '19 22:10 daniellockard

@daniellockard to confirm: would this is would result in a compile-time breaking API change?

theckman avatar Feb 20 '21 17:02 theckman

This PR was opened quite some time ago. I haven't actually looked at pagerduty anything in quite some time. I believe it would as it changes the types of images and links to actual types.

daniellockard avatar Feb 22 '21 15:02 daniellockard

@daniellockard thank you for taking the time to comment. That makes sense, and I'll keep this PR on-deck for whenever we look to release v2.0.0. Thank you for the contribution, and I apologize for it taking so long to get some sort of resolution on this.

theckman avatar Feb 23 '21 10:02 theckman