Daniel Schmidt

Results 29 comments of Daniel Schmidt

@wKovacs64 ```js if (process.env.NODE_ENV === 'test' || process.env.NODE_ENV === 'development') { const { worker } = require('./mocks') worker.start() } ``` This allows the bundler to eliminate the dead code paths,...

Option 2 sounds like the thing. You could use "!" in the glob to exclude specific subdirs.

See https://github.com/Acidic9/tailwind-classes-sorter/issues/4 A fix is to disable `JIT` for formatting, by changing the `tailwind.config.js`: ```js module.exports = { // This "hack" ensures your IDE detects all normal Tailwind classes, while...

I'd recommend switching to https://github.com/francoismassart/eslint-plugin-tailwindcss with `--fix` to handle the sorting. It handles `jit` mode perfectly. To keep IDE code completion working with, I still include the `NODE_ENV` toggle above,...

Thinking it would make sense to simply have it skip running the `prettier` task if the `options` are `undefined`. It's just used to by Jest to ensure consistent formatting of...

I've got a similar usecase, but not using spread when injecting the props. ``` javascript // ILink.js import {PropTypes} from 'react'; export default PropTypes.shape({ url: PropTypes.string.isRequired, selected: PropTypes.bool, target: PropTypes.string,...

Hey @brandonkal Thanks for letting me know. When using the Hook, you should be sure that the focus trap can actually get focus. A quick look at your code, and...

Regarding the `fallbackFocus`, the hook takes options, that currently support a `focusSelector` value. This is a `querySelector` string that's used to set the initial focus. Is this what you are...

That makes sense. I hadn't seen the `focus-trap` library before. I think I'll look into using that instead, and in the process also supporting the options it contains.