theanarkh
theanarkh
@pinca I've read the source code. I think 'bytesWritten' is equal to the length of all written bytes, which includes the data has been sent and data is waiting to...
Oh. Thanks. `bufferSize = this.bytesWritten - this._bytesDispatched + this._handle.writeQueueSize` is it right ?
> Can you add a test where those are non-zero? Done ! Thanks !
@mcollina Hi, can help review this PR again ? Thanks !
It failed on Windows. ``` node:assert:124 throw new AssertionError(obj); ^ AssertionError [ERR_ASSERTION]: Expected values to be strictly equal: 0 !== 10 ``` It seems windows writes the data into os...
@mcollina Hi , can help review again ? Thanks .
@mcollina Hi , can help review again ?
@jasnell @addaleax Hi, can you help review this PR ? Thanks !
The CI always fails on Windows, but it seems it is not related to this PR.