Yuan Tang
- [x] Fixed in https://github.com/argoproj/argo-workflows/pull/11056 ``` --- FAIL: Test_createSecretVolumesFromArtifactLocations_SSECUsed (0.01s) panic: runtime error: invalid memory address or nil pointer dereference [recovered] panic: runtime error: invalid memory address or nil pointer...
- [x] https://github.com/argoproj/argo-workflows/pull/11060 ``` functional_test.go:736: Error Trace: /home/runner/work/argo-workflows/argo-workflows/test/e2e/functional_test.go:736 /home/runner/work/argo-workflows/argo-workflows/test/e2e/fixtures/then.go:68 /home/runner/work/argo-workflows/argo-workflows/test/e2e/fixtures/then.go:43 /home/runner/work/argo-workflows/argo-workflows/test/e2e/functional_test.go:735 Error: Not equal: expected: "Failed" actual : "Running" Diff: --- Expected +++ Actual @@ -1,2 +1,2 @@ -(v1alpha1.WorkflowPhase) (len=6)...
Keep open
- [x] https://github.com/argoproj/argo-workflows/pull/11346 ``` hooks_test.go:419: [1000](https://github.com/argoproj/argo-workflows/actions/runs/5524469870/jobs/10077534051?pr=11338#step:16:1001) Error Trace: /home/runner/work/argo-workflows/argo-workflows/test/e2e/hooks_test.go:419 [1001](https://github.com/argoproj/argo-workflows/actions/runs/5524469870/jobs/10077534051?pr=11338#step:16:1002) /home/runner/work/argo-workflows/argo-workflows/test/e2e/fixtures/then.go:68 [1002](https://github.com/argoproj/argo-workflows/actions/runs/5524469870/jobs/10077534051?pr=11338#step:16:1003) /home/runner/work/argo-workflows/argo-workflows/test/e2e/fixtures/then.go:43 [1003](https://github.com/argoproj/argo-workflows/actions/runs/5524469870/jobs/10077534051?pr=11338#step:16:1004) /home/runner/work/argo-workflows/argo-workflows/test/e2e/hooks_test.go:417 [1004](https://github.com/argoproj/argo-workflows/actions/runs/5524469870/jobs/10077534051?pr=11338#step:16:1005) Error: Not equal: [1005](https://github.com/argoproj/argo-workflows/actions/runs/5524469870/jobs/10077534051?pr=11338#step:16:1006) expected: "1/1" [1006](https://github.com/argoproj/argo-workflows/actions/runs/5524469870/jobs/10077534051?pr=11338#step:16:1007) actual : "2/2" [1007](https://github.com/argoproj/argo-workflows/actions/runs/5524469870/jobs/10077534051?pr=11338#step:16:1008) [1008](https://github.com/argoproj/argo-workflows/actions/runs/5524469870/jobs/10077534051?pr=11338#step:16:1009) Diff: [1009](https://github.com/argoproj/argo-workflows/actions/runs/5524469870/jobs/10077534051?pr=11338#step:16:1010)...
- [x] https://github.com/argoproj/argo-workflows/pull/11378 ``` cli_test.go:360: Error Trace: /home/runner/work/argo-workflows/argo-workflows/test/e2e/cli_test.go:360 /home/runner/work/argo-workflows/argo-workflows/test/e2e/fixtures/then.go:265 /home/runner/work/argo-workflows/argo-workflows/test/e2e/cli_test.go:357 Error: "[log-problems-n4r8n-report-4285119875: one log-problems-n4r8n-report-3816278739: three log-problems-n4r8n-report-4205137589: four log-problems-n4r8n-report-803032099: five]" should have 5 item(s), but has 4 Test: TestCLISuite/TestLogProblems ```
Another one: https://github.com/argoproj/argo-workflows/pull/11384
Hooks tests are very flaky. Disabled them for now. Need to investigate potential bugs: - [ ] https://github.com/argoproj/argo-workflows/pull/11406 - [ ] https://github.com/argoproj/argo-workflows/pull/11384 cc @toyamagu-2021 Would you like to help us...
I haven't got a chance to look into details yet but would this be a breaking change for current users who rely on mutexes?
+1 This would be great to have. I left a comment in https://github.com/kserve/kserve/issues/3561#issuecomment-2051872694. Feel free to join and discuss how the integration looks like.
1. Where is the naming convention for `default_optimizer` from? If necessary, we can change this in ElasticDL. ElasticDL also supports passing different names for optimizer/loss/etc. 2. We need to provide...