community

community copied to clipboard

Use this issue type to request a new repo in knative-extensions (or knative, which may require additional discussion).

Repo information

Org: knative-extensions

Repo: autoscaler-keda

Go module (Optional): knative.dev/serving-keda

Purpose (Description): This project targets to be a drop in replacement for the Knative Serving autoscaler-hpa component, using keda for hpa management. For more details and a demo check https://github.com/skonto/serving-keda/blob/main/README.md.

Sponsoring WG: Serving and Operations.

Related issue: https://github.com/knative/serving/issues/14877

Actions to fulfill

This area is used to track the repo creation process. The requestor and sponsoring WG lead should perform the steps listed below and cross out the checkmarks when done. The TOC is involved only in the TOC Gate steps.

• [x] Add this issue to the TOC project board for review. You are responsible for moving your entry on the board to "Needs Discussion" or "In Progress" as you move forward in this checklist.

You may not be able to use the Projects quick menu on this page. In that case, go to the project board and use the Add cards interface.

• [x] Send a PR adding entries for this repo in /peribolos/knative-extensions.yaml. Please mind the alphabetical order when adding to a list.
  • [x] Add the repository and a description.
  • [x] Grant Knative Admin the admin privilege.
  • [x] Grant the sponsoring WG the write privilege.

TOC Gate: Once the TOC has approved the above, it will merge and Peribolos will create an empty repository.

• [x] (golang) Send a PR to add aliases for knative.dev/$REPONAME import paths (sample).

• [x] Have a lead from the sponsoring WG bootstrap the Git repository by using an appropriate "template" repository (basic, sample-controller, sample-source).

  Follow the instructions from Creating a repository from a template

• [x] Send a PR adding the repo to knobots. Then run the community files update action to propagate new OWNER_ALIASES.

• [x] Add your GitHub Team to the OWNERS file for your repo.

• [x] Set up prow for a new repo

• [x] Bootstrap your CI jobs using hack project (look at other extensions repos for reference)

• [x] Create a sample PR to verify Prow (e.g., edit the boilerplate README)

• [x] Verify that within 24 hours the appropriate branch protections have been applied requiring tide to pass before PRs are merged.

• [ ] (optional) Send a PR adding the repo to CLOMonitor (more information).

cc @dprotaso @ReToCode

I am open to suggestions for the name.

Thanks for raising this, I think this would be a great addition.

wrt/ name, why not just autoscaler-keda (to align with autoscaler-hpa) ? I think this is simple and clearly states the purpose.

+1 on Rolands proposal. This also points out that this is our "KEDA-integration".

Changed to autoscaler-keda. Initially I had it autoscaler-keda-hpa but it is a bit verbose.

+1 to the autoscaler-keda name.

It make senses in a greater picture with prefix associations to certain WG as well.

cc @davidhadas @cardil @upodroid @krsna-m any objections for approving this?

+1 from me

hi, As this is sponsored by Serving, we should wait for @dprotaso to comment before moving forward to create the repo. Other than that, looks fine to me.

+1 from me

+1 !!!!!!!! I have linked to the KServe issue https://github.com/kserve/kserve/issues/3561

Hi, knative folks 👋 Are there any updates to introduce KEDA extensions? I'd be looking forward to adding this extension since I'd like to use Kserve's https://github.com/kserve/kserve/issues/3561 feature.

+1 This would be great to have. I left a comment in https://github.com/kserve/kserve/issues/3561#issuecomment-2051872694. Feel free to join and discuss how the integration looks like.

Are there any updates to introduce KEDA extensions?

I will start working on this next week. RH Serving folks are off this week.

+1