Tom Dyas

Results 151 comments of Tom Dyas

> @tdyas if the docker runner can execute concurrently in an image with the concurrent runs accessing the same underlying PEX_ROOT / named_caches (do those work for the docker runner?),...

The [arborist NPM package](https://www.npmjs.com/package/@npmcli/arborist) may be useful in parsing and manipulating NPM lockfiles.

> @tdyas We've discussed selecting the C or C++ compiler based on file extensions, but we would also need a workflow around compiling .c files using a C++ compiler (which...

> > Just have the user specify C++ tool names for the C-related tool names option? > > Re (2), this would also imply creation of Objective-C and other targets...

> However, with @tdyas's cgo PR in the mix, it seems like a good time to bikeshed on target and subsystem naming, determining how consistent we want to keep names...

This PR currently vendors the Tower `TimeoutLayer` in order to allow the addition of a timeout metric. I am not enamored with this approach. I am going to experiment with...

(Forgot to mark this for review so I could ask the question in earlier comment. Doing so now. Doh.)

> I'm not following why we need to vendor, rather than importing the code? Just look at the Pants-specific code in the file that accesses workunit store ...

... which relates to my comment at https://github.com/pantsbuild/pants/pull/16196#issuecomment-1185897383 about finding a different way to be able to increment that counter.