Tom Dyas

Results 151 comments of Tom Dyas

Open question: Should typescript files be included in `javascript_sources` targets? NPM files may validly have a mixture of both `.ts` and `.js` files in the same directory. - Typescript files...

> I also realized we don't handle `../` at all 😮‍💨 In what way?

> The symlink oblivious DigestTrie traversal doesn't do anything special for parent dirs, so it'll always count as as a "miss" To clarify, for the following `Digest`, it would not...

> Not yet no. I'm guessing we'll have to handle it by also keeping the Trie root around and just resolving symlinks from the root using the fully resolved canonical...

Note: `go generate` is never run automatically. This would probably have to be a Go-specific goal if Pants were to support it. For now, users can work-around the lack of...

> What benefit would Pants bring that you don't get from using Go directly? I'm not sure I agree this is a feature worth adding and maintaining. Context: User request...

And I agree with your assessment that this is not a high priority. This issue will at least give users a place to weigh in on our assessment.

https://github.com/pantsbuild/pants/pull/16909 adds support for a `go-generate` goal.

The failed tests succeed if re-run. Could be some sort of race condition.