Stijn de Gooijer

Results 573 comments of Stijn de Gooijer

I looked into this. It should be easy enough to augment the [`parse_pyproject_toml` function](https://github.com/psf/black/blob/eaa048925e4443cc0e2b57b795f2852bedb4287f/src/black/files.py#L105) to also read the `project.requires-python` field. However, parsing that field is another matter. We would probably...

I indeed looked at poetry-core for the version parsing. But if you wanted to use their version parser (it's quite extensive), you'd have to add it as a dependency, which...

Sure, I'll give that a shot! Will report back.

> Can you try https://marketplace.visualstudio.com/items?itemName=matklad.rust-analyzer instead (though it might be a bit finicky to set up in WSL -- you need to install it on the remote side and make...

I'll still keep this issue open for now, as it seems relevant to the Rust extension. My first impression of `rust-analyzer` is that it tries to do too much; I...

Thanks for the comments so far! I came up with the missing logic for handling some of the special cases. The result isn't super pretty, but I believe it works....

@ichard26 Would you be willing to take another look at this? We can also conclude that this kind of complexity is not what we want right now, for the small...

I saw I missed a mypy linting error. I rebased the branch and added a commit to fix the issue. The diff-shades checks are still failing, but I'm not sure...

Had to rebase due to #3233 . Should be good to go!

> I've been a really bad maintainer, but I promise I've started reviewing this. It overall looks great, I just have a few code style remarks and I want to...