Matija Marohnić

Results 237 comments of Matija Marohnić

Please share how you're calling `setComment`, that's crucial information. I don't know TypeScript so I'm not familiar with its errors, but it seems like it should be: ```ts // I'm...

I'm still very new to this project, but yeah, it looks like kind types should be exposed in `main.d.ts`.

To me this seems like a good idea in general (performance-wise), regardless of the bug.

How about using a local cache to store file content based on `this.resourcePath`? That way you can check contents without IO.

I'm not using Flow nor CSS Modules anymore, so not invested 🤷

`flex: 30px` means `flex: 0 0 30px` in IE10 instead of `flex: 0 1 30px`, so we do have to expand it :confused: Check out the [updated Flexbug 6](https://github.com/philipwalton/flexbugs#6-the-default-flex-value-has-changed).

Does `flex: 30px` really just do `flex-basis: 30px`? My CSS-fu is a bit rusty, but I think CSS shorthands set everything else to default: ``` css flex-shrink: 5; flex: 30px;...

Nice catch, you could perhaps raise an issue in DevTools.

The problem is in the Toaster component: https://github.com/timolins/react-hot-toast/blob/c5e59351d511d8702b065378a6859c795b05547d/src/components/toaster.tsx#L84-L88 In jsdom `getBoundingClientRect` used in `createRectRef` always returns an object of zeros, so the ref created `createRectRef` just gets created and run...